Remove serverAddress from Feeds and FeedEpisodes URLs #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I have not deleted the serverAddress column in the feeds table, and it is still set when creating new RSS feeds. While it's not used anymore in the code, it is stored in order to be used in downward migrations. If there are no issues with the new code, we can decide to remove it in some future migration. |
advplyr
reviewed
Dec 7, 2024
|
I fixed the two issues you mentioned. PTAL again. |
|
Working well with & without router base path. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
This fixes #3563, and also makes the necessary preparation for subdirectory support for RSS feeds.
Which issue is fixed?
Fixes #3563
In-depth Description
This removes the protocol and host from all URLs in the Feeds and FeedEpisodes tables (including a migration that changes existing records). The host and protocol are now dynamically determined at runtime based on the request.
The web client is also modified to handle the shortened URLs.
This achieves 2 goals:
How have you tested this?
The migration (both up and down) has been unit tested and also tested against a real ABS database.
Modifications to server and client were tested with both existing (non-subdirectory) and subdirectory builds. The server and client were accessed through different server addresses and behaved correctly: